library: Ported Menu Button in rust
#552
Conversation
| let primary_button: Button = workbench::builder() | ||
| .object("primary") | ||
| .expect("Failed to get primary_button"); | ||
| let secondary_button: Button = workbench::builder() |
There was a problem hiding this comment.
That should be a MenuButton not a Button
There was a problem hiding this comment.
Have you tried the code?
it doesn't look like it would work. I also don't think it's formatted.
There was a problem hiding this comment.
I forgot to add an import, it works on my side now + did the formatting.
Pls check :)
There was a problem hiding this comment.
Doesn't look formatted to me :)
Please run the code in Workbench, that will format it.
Then copy the result to code.rs.
See here:
#554 (comment)
There was a problem hiding this comment.
Also, I ran the code and copy-pasted it as you asked. Let me know if its correctly formatted now
There was a problem hiding this comment.
The code looks good now.
you don’t have to remove your name, you should resolve the conflict in a way that all of the additions are there. You can give it a try by clicking on “Resolve conflicts” on this page
There was a problem hiding this comment.
I tried that, but I cant figure it out. Could you please help out?
There was a problem hiding this comment.
I've done it for you.
You can see how in this screencast, so you can try next time on your own :)
screencast
There was a problem hiding this comment.
Thank you! I will look at the screencast. Much appreciated
Co-authored-by: Hofer-Julian <[email protected]>
|
After your approval @sonnyp, we can merge this |
Added menu button implementation in rust.
Preview looks fine, but two errors are seen on the console that I cant seem to understand what they are about
They dont seem to effect the preview or Rust code.
Review please!