library: Ported Switch to RUST
#561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hofer-Julian
requested changes
Aug 30, 2023
onkarrai06
force-pushed
the
Workbench-Switch
branch
from
119eb2d
to
90ab009
Compare
saadulkh
suggested changes
Aug 31, 2023
|
The suggestions above work on my side, waiting on final review :) |
Hofer-Julian
approved these changes
Aug 31, 2023
There was a problem hiding this comment.
The code looks good to me.
If @saadulkh can confirm that it works as expected, I will merge it.
Otherwise, I'll check tomorrow.
|
Tried code from the latest commit 2980d94 Thanks for the addition. @onkarrai06 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Read the JS code and tried to convert it to RUST. However, this has an ownership error that I can't seem to resolve as Switch does not implement Copy. Would appreciate any help as I've spent a long time on this.