Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manuals: Optimize loading docs #573

Merged
merged 5 commits into from
Sep 12, 2023
Merged

Conversation

AkshayWarrier
Copy link
Contributor

@AkshayWarrier AkshayWarrier commented Sep 5, 2023

This PR improves the time it takes to create and load the sidebar.
Thanks @andyholmes :)
https://gitlab.gnome.org/-/snippets/6127

@AkshayWarrier AkshayWarrier marked this pull request as ready for review September 11, 2023 15:19
@sonnyp sonnyp requested review from andyholmes and removed request for sonnyp September 11, 2023 15:22
@sonnyp
Copy link
Contributor

sonnyp commented Sep 11, 2023

Assigned @andyholmes who is the author of the snippet.

But yey it's instantaneous now!

src/DocumentationViewer.js Outdated Show resolved Hide resolved
Copy link
Contributor

@andyholmes andyholmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good, just a few tweaks.

src/DocumentationViewer.js Outdated Show resolved Hide resolved
src/DocumentationViewer.js Outdated Show resolved Hide resolved
src/DocumentationViewer.js Show resolved Hide resolved
@AkshayWarrier
Copy link
Contributor Author

I made the changes and I also realized that StringSorter wasn't working in the browse model so I switched back to using CustomSorter

Copy link
Contributor

@andyholmes andyholmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andyholmes andyholmes merged commit cd99aaa into main Sep 12, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants