-
-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Blueprint formatter support #583
Conversation
59a65a5
to
94b1608
Compare
popover: EmojiChooser emoji_chooser {}; | ||
|
||
styles ["pill", "emoji"] | ||
popover: EmojiChooser emoji_chooser { | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gregorni I wonder if the formatter shouldn't close empty objects inline
popover: EmojiChooser emoji_chooser {}
wdyt?
primary: true; // May not work in Previewer | ||
primary: true; | ||
// May not work in Previewer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gregorni do you think it's feasable to preserve inline comments?
Makefile
Outdated
# gettext | ||
find po/ -type f -name "*po" -print0 | xargs -0 -n1 msgfmt -o /dev/null --check | ||
# Flatpak manifests | ||
flatpak run --user --command=flatpak-builder-lint org.flatpak.Builder manifest --exceptions build-aux/re.sonny.Workbench.json | ||
flatpak run --user --command=flatpak-builder-lint org.flatpak.Builder manifest --exceptions build-aux/re.sonny.Workbench.Devel.json | ||
# Blueprint | ||
# find src -type f -name "*blp" -print0 | xargs -0 blueprint-compiler format | ||
find src -type f -name "*blp" -print0 | xargs -0 flatpak run --command=/app/bin/blueprint-compiler --filesystem=host:rw re.sonny.Workbench.Devel//master format |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've asked James if we could pip-ify Blueprint compiler
package.json
Outdated
"*.rs": "flatpak run --user --command=/usr/lib/sdk/rust-stable/bin/rustfmt --filesystem=host org.gnome.Sdk//45 --edition 2021" | ||
"*.py": "./build-aux/black.sh", | ||
"*.rs": "flatpak run --user --command=/usr/lib/sdk/rust-stable/bin/rustfmt --filesystem=host org.gnome.Sdk//45 --edition 2021", | ||
"*.blp": "flatpak run --command=/app/bin/blueprint-compiler --filesystem=host:rw re.sonny.Workbench.Devel//master format --fix" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
@gregorni is working on a Blueprint formatter 🚀
https://gitlab.gnome.org/jwestman/blueprint-compiler/-/merge_requests/124
Test with
CI / pre-commit hook isn't included yet - see the comment in
Makefile