replace logError with console.error() #592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonnyp
requested changes
Sep 16, 2023
src/Library/demos/Account/main.js
Outdated
Comment on lines
50
to
52
| onClicked().catch((err)=>{ | ||
| console.error(err); | ||
| }); |
There was a problem hiding this comment.
Why didn't you use the original syntax.
I don't have a strong opinion but I'm curious to know if there is a reason to use an anonymous function
Suggested change
| onClicked().catch((err)=>{ | |
| console.error(err); | |
| }); | |
| onClicked().catch(console.error); |
There was a problem hiding this comment.
No particular reason but i just went with it, I've updated it though
|
I can't access |
* library: Add Rust demo Map * remove unused variable * Ensure Shumate type in Vala * Add `gtk::init` * Slightly simplify println --------- Co-authored-by: Julian Hofer <[email protected]>
Co-authored-by: Sonny Piers <[email protected]>
|
Yes, you should make changes to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #531