library: Add Language and Category filters #967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial implementation to add filters for demos
sonnyp
reviewed
Jul 14, 2024
There was a problem hiding this comment.
Good start
I merged main into this branch, make sure to git pull
A few points
We shouldn't repeat the languages / categories - you can constructs the GTK from JavaScript
We shouldn't use human strings such as “All Languages” to keep track of the currently selected item. Use the index or some constant.
sonnyp
reviewed
Jul 14, 2024
Set dropdown to flat style Construct dropdown values from JavaScript Logic change for filtering, make use of index values instead of strings
andyholmes
reviewed
Jul 24, 2024
There was a problem hiding this comment.
This is looking good.
I guess based on #510 this will eventually use a list model of demos with a GridView, so the filtering logic can be re-used later with GtkExpressions.
Static maps for all category and Language filter strings style change for "No results" label
andyholmes
reviewed
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial implementation to add language and category filters for available demos.
Minor issue
With the current implementation theDropdownuses aStringListto store the names of the categories, andPlatform APIsas a category only shows demos if the category is namedPlatformin the string list. Therefore the category in the dropdown is also shown asPlatforminstead of the idealPlatform APIsScreengrab of it in action:
2024-07-12.01-19-07.mp4
Let me know if there are any issues with the implementation :)
Current state [commit]
2024-07-29.12-30-23.mp4