Make Postgres setup mandatory #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove `memory` feature - Start testing with real Postgres database - Remove `postgres` feature and make its functionality default - Update GitHub actions to create Docker images without feature - Remove testing on macOS in GitHub workflow, Docker is not supported
justim
force-pushed
the
remove-memory-feature
branch
from
7849a1d to
29d48ba
Compare
Using an `Option` does not clearly indicate what's happening, using an enum with proper names makes the options very clear.
Use the database directly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
memoryfeaturepostgresfeature and make its functionality default