Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed name of podman-compose.yaml to compose.yaml #23

Merged
merged 2 commits into from
Oct 28, 2024

Conversation

dave-meyer
Copy link
Contributor

  • I propose changing the name of the podman-compose.yaml file to just compose.yaml, which ensures compatibility with both podman and docker. I tested it and it works out-of-the-box with both podman (v1.13.3) and docker on Windows.
  • I also propose replacing the podman-compose command with podman compose, as this seems to be the way to go according to the current podman documentation. Also, podman-compose did not work out of the box for me, whereas podman compose did work.
  • Finally, I propose adding the docker compose up command to the readme, to make it easier for non-podman users to get started.

I am open to other suggestions and/or feedback!

…ith docker. Changed 'podman-compose' command to 'podman compose' in readme (according to podman docs). Added docker command to readme as an alternative to podman.
@hwo-wd
Copy link
Member

hwo-wd commented Oct 28, 2024

lgtm; thanks for the pointers about podman-compose <-> podman compose, seems as if RedHat is going through the same evolution as Docker Inc. did :D.
Thanks!

@hwo-wd hwo-wd merged commit d6435d0 into world-direct:main Oct 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants