Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor database environment variables to postgres nomenclature #46

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Refactor database environment variables to postgres nomenclature #46

merged 1 commit into from
Sep 5, 2024

Conversation

zacdezgeo
Copy link
Collaborator

What I Changed

From @bitner on #41, I modified the environment variables to match Postgres' nomenclature.

How to Test it

  • Run space2stats_api unit tests : python -m pytest tests
  • Run the application locally: uvicorn src.space2stats.app:app --reload and run through the blocks of notebooks/space2stats_api_demo.ipynb after defining the API URL to http://localhost:8000

@zacdezgeo zacdezgeo added documentation Improvements or additions to documentation enhancement New feature or request labels Sep 4, 2024
@zacdezgeo zacdezgeo self-assigned this Sep 4, 2024
@zacdezgeo zacdezgeo merged commit ff08239 into acceptance/db Sep 5, 2024
2 checks passed
@zacdezgeo zacdezgeo deleted the refactor/pg-env branch September 5, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincentsarago vincentsarago vincentsarago approved these changes

@bitner bitner Awaiting requested review from bitner

@alukach alukach Awaiting requested review from alukach

Assignees

@zacdezgeo zacdezgeo

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zacdezgeo @vincentsarago