Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-write unit tests relying on API calls using mocking #22

Open
tonyfujs opened this issue Mar 31, 2022 · 0 comments
Open

Re-write unit tests relying on API calls using mocking #22

tonyfujs opened this issue Mar 31, 2022 · 0 comments
Assignees

Comments

@tonyfujs
Copy link
Member

Currently, the some unit tests call the PIP API live. This is problematic for a few reasons:

  • Unit tests will fail if the API is down
  • Unit tests will fails if the API response changes
  • CRAN submission will potentially be rejected for this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants