Fix scaffolding paths #192
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes wp-cli#188 Approach: Modify the file-paths copied * `wp-cli/wp-cli/ci/behat-tags.php` -> `./utils/behat-tags.php` * `wp-cli/wp-cli/features/bootstrap/FeatureContext.php` -> `wp-cli/wp-cli-tests/features/bootstrap/FeatureContext.php` * `wp-cli/wp-cli/features/bootstrap/support.php` -> `wp-cli/wp-cli-tests/features/bootstrap/support.php` * `wp-cli/wp-cli/features/steps/given.php` -> `wp-cli/wp-cli-tests/features/steps/given.php` * `wp-cli/wp-cli/features/steps/when.php` -> `wp-cli/wp-cli-tests/features/steps/when.php` * `wp-cli/wp-cli/features/steps/then.php` -> `wp-cli/wp-cli-tests/features/steps/then.php` * `wp-cli/wp-cli/features/extra/no-mail.php` -> `wp-cli/wp-cli-tests/features/extra/no-mail.php`
Noticed this file is not 1:1 with the one from this repo...
|
Here are three artifacts from a local build with the copied files. I need to run this on a different machine as it fails on composer after these are generated. I Do not believe this is due to these changes. wp-cli-test-run-scaffold-package.feature.113-5fb65ebbdbded9.46320105.zip |
|
Closing this PR, as the changes in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #188
Approach:
Modify the file-paths copied
notation: source -> dest (vendor path omitted)
wp-cli/wp-cli/ci/behat-tags.php->./utils/behat-tags.phpwp-cli/wp-cli/features/bootstrap/FeatureContext.php->wp-cli/wp-cli-tests/features/bootstrap/FeatureContext.phpwp-cli/wp-cli/features/bootstrap/support.php->wp-cli/wp-cli-tests/features/bootstrap/support.phpwp-cli/wp-cli/features/steps/given.php->wp-cli/wp-cli-tests/features/steps/given.phpwp-cli/wp-cli/features/steps/when.php->wp-cli/wp-cli-tests/features/steps/when.phpwp-cli/wp-cli/features/steps/then.php->wp-cli/wp-cli-tests/features/steps/then.phpwp-cli/wp-cli/features/extra/no-mail.php->wp-cli/wp-cli-tests/features/extra/no-mail.phpNote: Takes passing Travis-CI tests from 49 -> 51 with no new errors (that I've noticed, it's all still some composer version error)