Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support background css property #91

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Support background css property #91

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
99d3022
adjust the regex
engahmeds3ed Dec 25, 2020
c17377a
add unit test fixtures
engahmeds3ed Dec 25, 2020
f9c9f3b
fix formatting
engahmeds3ed Dec 25, 2020
252aae9
use wp_strip_all_tags instead of strip_tags
engahmeds3ed Dec 25, 2020
6239853
make <before> accept any character
engahmeds3ed Dec 29, 2020
dda58ad
add more test cases with hex colors at the end
engahmeds3ed Dec 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
use wp_strip_all_tags instead of strip_tags
  • Loading branch information
@engahmeds3ed
engahmeds3ed committed Dec 25, 2020
commit 252aae9759b5909ccffcc11cb3b12e04b83df4ca
2 changes: 1 addition & 1 deletion src/Image.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ public function lazyloadBackgroundImages( $html, $buffer ) {

$url['url'] = esc_url(
trim(
strip_tags(
wp_strip_all_tags(
html_entity_decode(
$url['url'],
ENT_QUOTES | ENT_HTML5
Expand Down
12 changes: 12 additions & 0 deletions tests/Unit/Image/TestLazyloadBackgroundImages.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,22 @@ public function testShouldReturnSameWhenNoBackgroundImage() {

public function testShouldReturnBackgroundImagesLazyloaded() {
Functions\when('esc_attr')->returnArg();

Functions\expect('esc_url')->andReturnUsing( function ( $url ){
return str_replace(['"', "'"], ["&quot;", "&#39;"], $url );
} );

Functions\expect('wp_strip_all_tags')->andReturnUsing( function ( $string, $remove_breaks = false ){
$string = preg_replace( '@<(script|style)[^>]*?>.*?</\\1>@si', '', $string );
$string = strip_tags( $string );

if ( $remove_breaks ) {
$string = preg_replace( '/[\r\n\t ]+/', ' ', $string );
}

return trim( $string );
} );

$original = \file_get_contents( RLL_COMMON_TESTS_ROOT . '/fixtures/Image/bgimages.html');
$expected = \file_get_contents( RLL_COMMON_TESTS_ROOT . '/fixtures/Image/bgimageslazyloaded.html');

Expand Down