Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate markdown rendering with writefreely #9

Open
eddsalkield opened this issue Sep 22, 2020 · 0 comments · May be fixed by #10
Open

Duplicate markdown rendering with writefreely #9

eddsalkield opened this issue Sep 22, 2020 · 0 comments · May be fixed by #10
Assignees
@eddsalkield

Comments

@eddsalkield
Copy link
Contributor

web-core depends on github.com/writeas/saturday to implement functions ApplyMarkdown and ApplyBasicMarkdown in posts/render.go. These functions are specific to the operation of writefreely. However, writefreely reimplements these functions as applyMarkdown and applyBasicMarkdown in postrender.go instead of using the implementations here in web-core.

Indeed, there does not exist any writeas repository that depends on either of those functions.

Therefore I suggest dropping the implementation of these functions from web-core. In so doing, we lose the dependency on github.com/writeas/saturday, simplifying the packaging process by reducing the need for bundling.
@eddsalkield eddsalkield linked a pull request Sep 22, 2020 that will close this issue
Open
@thebaer thebaer linked a pull request Sep 24, 2020 that will close this issue
Prune redundant posts/render.go #10
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eddsalkield eddsalkield

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prune redundant posts/render.go eddsalkield/web-core
1 participant
@eddsalkield