Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor talk video pages (again) #2160

Open
plaindocs opened this issue Jun 7, 2024 · 1 comment
Open

Refactor talk video pages (again) #2160

plaindocs opened this issue Jun 7, 2024 · 1 comment

Comments

@plaindocs
Copy link
Contributor

We used to generate all the video pages on the fly. And the build took ages, so we only build videos specifically if you turn it on, or on deployment.

Now we generate page stubs outside of the usual build, and commit the result. Although the stubs still load data from the YAML files. 🤷‍♂️

Running a clean build on my laptop without building videos:

real	1m42.046s
user	4m42.646s
sys	0m10.230s

Running a clean build on my laptop building videos:

real	2m43.086s
user	7m35.735s
sys	0m11.698s

It's slower, but is it slower enough for the extra logic? @mxsasha

@plaindocs
Copy link
Contributor Author

plaindocs commented Jun 7, 2024

If we want to keep the current method, we could also write the entire page instead of using

A Year in the Life of The Better Docs Project
=============================================

.. datatemplate-video::
   :source: /_data/2018.prague.speakers.yaml
   :template: videos/video-detail.html
   :key: 3

which would presumably be faster?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant