Skip to content
This repository has been archived by the owner on Sep 5, 2020. It is now read-only.

Squash "access to protected member of a class" warnings in cint API #17

Open
Utumno opened this issue Oct 28, 2016 · 2 comments
Open

Squash "access to protected member of a class" warnings in cint API #17

Utumno opened this issue Oct 28, 2016 · 2 comments
Labels
enhancement Request to add or enhance a feature. papi Issue is primarily related to the Python API.
Milestone

Comments

@Utumno
Copy link
Member

Utumno commented Oct 28, 2016

Pycharm emits no less than 120 warnings outside cint on _RecordID, _Type (Type ?), and _ModID attributes access. Although as we discussed PEP8'ing the API is not an immediate priority (although should be done in the final API), those in particular should be squashed in the next API iteration (and _Type renamed to something more descriptive).

In general I have painfully and meticulously squashed 1000s of warnings and those were of the most annoying kind, as I could not/would not mess with cint. I will be very glad to see those squashed.

@Utumno Utumno added TODO Specific item that needs to be accomplished in working towards a goal. papi Issue is primarily related to the Python API. labels Oct 28, 2016
@leandor
Copy link
Contributor

leandor commented Oct 28, 2016

Yeah, you mean these kind of warnings, right?

image

I believe those are totally an artifact of the way cint wraps the C interface today, I'd hope all of that won't be needed at all when the actual API can be published in full.

Of course, it may mean having to do some changes on the code base, if/when there is code that depends on those actual wrappers existing... I'll try to mimic them the best I can, and if so, I'll totally provide a more clear interface w.r.t. names and style.

@Utumno
Copy link
Member Author

Utumno commented Oct 28, 2016

Yep - underscore prepended names in python are considered private - a convention mainly which I have been putting into good use since I started refactoring. So all those slots should not start with an underscore - and then be lowercase (cause CamelCase is for types in python).

Just a head's up, probably will just disappear with cint :)

@Infernio Infernio added enhancement Request to add or enhance a feature. and removed TODO Specific item that needs to be accomplished in working towards a goal. labels Sep 20, 2019
@Infernio Infernio added this to the 0.8.0 milestone Sep 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Request to add or enhance a feature. papi Issue is primarily related to the Python API.
Projects
None yet
Development

No branches or pull requests

3 participants