Template IdV event listener #6242
Open
+16
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6242 +/- ##
==========================================
Coverage 45.69% 45.70%
+ Complexity 14077 14058 -19
==========================================
Files 1633 1633
Lines 100914 100656 -258
Branches 17730 17696 -34
==========================================
- Hits 46115 46002 -113
+ Misses 48082 47958 -124
+ Partials 6717 6696 -21
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Template to change the default execution order id (which is 150 [1] ), since the default order id was overridden by another listener.
The selected default order id is
120, which is not occupied by otherUserOperationEventListenerlisteners.Note : In Asgardeo, this issue does not exist because the
IdVUserOperationEventListeneris configured with a priority of 120 through the deployment.toml file. Refer [2].[1] https://github.com/wso2-extensions/identity-verification/blob/67a61a7d9498b037dad05f0a351bf057a6eee49b/components/org.wso2.carbon.extension.identity.verification.mgt/src/main/java/org/wso2/carbon/extension/identity/verification/mgt/listeners/IdVUserOperationEventListener.java#L283
[2] https://github.com/wso2-enterprise/asgardeo-deployment-helm-is/blame/8c9794eaf031298018538b8f608a8427b17fd80d/confs/deployment.toml#L2512C12-L2512C12