Resolve PR comments

wso2 · Oct 15, 2024 · 9088953 · 9088953
1 parent e8f0e5a
commit 9088953
Show file tree

Hide file tree

Showing 6 changed files with 28 additions and 23 deletions.
diff --git a/...rver.claim.management/org.wso2.carbon.identity.api.server.claim.management.common/pom.xml b/...rver.claim.management/org.wso2.carbon.identity.api.server.claim.management.common/pom.xml
@@ -1,18 +1,20 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <!--
-  ~ Copyright (c) 2019, WSO2 Inc. (http://www.wso2.org) All Rights Reserved.
+  ~ Copyright (c) 2019-2024, WSO2 LLC. (http://www.wso2.com).
   ~
-  ~ Licensed under the Apache License, Version 2.0 (the "License");
-  ~ you may not use this file except in compliance with the License.
+  ~ WSO2 LLC. licenses this file to you under the Apache License,
+  ~ Version 2.0 (the "License"); you may not use this file except
+  ~ in compliance with the License.
   ~ You may obtain a copy of the License at
   ~
   ~ http://www.apache.org/licenses/LICENSE-2.0
   ~
-  ~ Unless required by applicable law or agreed to in writing, software
-  ~ distributed under the License is distributed on an "AS IS" BASIS,
-  ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-  ~ See the License for the specific language governing permissions and
-  ~ limitations under the License.
+  ~ Unless required by applicable law or agreed to in writing,
+  ~ software distributed under the License is distributed on an
+  ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+  ~ KIND, either express or implied.  See the License for the
+  ~ specific language governing permissions and limitations
+  ~ under the License.
   -->
 
 <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">

diff --git a/...rg/wso2/carbon/identity/api/server/claim/management/common/ClaimManagementDataHolder.java b/...rg/wso2/carbon/identity/api/server/claim/management/common/ClaimManagementDataHolder.java
@@ -29,14 +29,12 @@ public class ClaimManagementDataHolder {
 
     private static class OrganizationManagerHolder {
         static final OrganizationManager SERVICE = (OrganizationManager) PrivilegedCarbonContext
-                .getThreadLocalCarbonContext()
-                .getOSGiService(OrganizationManager.class, null);
+                .getThreadLocalCarbonContext().getOSGiService(OrganizationManager.class, null);
     }
 
     private static class ClaimMetadataManagementServiceHolder {
         static final ClaimMetadataManagementService SERVICE = (ClaimMetadataManagementService) PrivilegedCarbonContext
-                .getThreadLocalCarbonContext()
-                .getOSGiService(ClaimMetadataManagementService.class, null);
+                .getThreadLocalCarbonContext().getOSGiService(ClaimMetadataManagementService.class, null);
     }
 
     /**

diff --git a/...ver.claim.management/org.wso2.carbon.identity.rest.api.server.claim.management.v1/pom.xml b/...ver.claim.management/org.wso2.carbon.identity.rest.api.server.claim.management.v1/pom.xml
@@ -1,18 +1,20 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <!--
-  ~ Copyright (c) 2019, WSO2 Inc. (http://www.wso2.org) All Rights Reserved.
+  ~ Copyright (c) 2019-2024, WSO2 LLC. (http://www.wso2.com).
   ~
-  ~ Licensed under the Apache License, Version 2.0 (the "License");
-  ~ you may not use this file except in compliance with the License.
+  ~ WSO2 LLC. licenses this file to you under the Apache License,
+  ~ Version 2.0 (the "License"); you may not use this file except
+  ~ in compliance with the License.
   ~ You may obtain a copy of the License at
   ~
   ~ http://www.apache.org/licenses/LICENSE-2.0
   ~
-  ~ Unless required by applicable law or agreed to in writing, software
-  ~ distributed under the License is distributed on an "AS IS" BASIS,
-  ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-  ~ See the License for the specific language governing permissions and
-  ~ limitations under the License.
+  ~ Unless required by applicable law or agreed to in writing,
+  ~ software distributed under the License is distributed on an
+  ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+  ~ KIND, either express or implied.  See the License for the
+  ~ specific language governing permissions and limitations
+  ~ under the License.
   -->
 
 <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">

diff --git a/...java/org/wso2/carbon/identity/rest/api/server/claim/management/v1/ClaimManagementApi.java b/...java/org/wso2/carbon/identity/rest/api/server/claim/management/v1/ClaimManagementApi.java
@@ -49,6 +49,7 @@ public class ClaimManagementApi  {
     private final ClaimManagementApiService delegate;
 
     public ClaimManagementApi() {
+
         this.delegate = ClaimManagementApiServiceFactory.getClaimManagementApi();
     }
 

diff --git a/...ty/rest/api/server/claim/management/v1/factories/ServerClaimManagementServiceFactory.java b/...ty/rest/api/server/claim/management/v1/factories/ServerClaimManagementServiceFactory.java
@@ -52,6 +52,7 @@ public class ServerClaimManagementServiceFactory {
      * @return ServerClaimManagementService
      */
     public static ServerClaimManagementService getServerClaimManagementService() {
+
         return SERVICE;
     }
 }
diff --git a/...rbon/identity/rest/api/server/claim/management/v1/impl/ClaimManagementApiServiceImpl.java b/...rbon/identity/rest/api/server/claim/management/v1/impl/ClaimManagementApiServiceImpl.java
@@ -19,6 +19,7 @@
 package org.wso2.carbon.identity.rest.api.server.claim.management.v1.impl;
 
 import org.apache.cxf.jaxrs.ext.multipart.Attachment;
+import org.apache.http.HttpHeaders;
 import org.wso2.carbon.identity.api.server.common.FileContent;
 import org.wso2.carbon.identity.rest.api.server.claim.management.v1.ClaimManagementApiService;
 import org.wso2.carbon.identity.rest.api.server.claim.management.v1.core.ServerClaimManagementService;
@@ -184,9 +185,9 @@ public Response exportClaimDialectToFile(String dialectId, String accept) {
                 .type(fileContent.getFileType())
                 .header("Content-Disposition", "attachment; filename=\""
                         + fileContent.getFileName() + "\"")
-                .header("Cache-Control", "no-cache, no-store, must-revalidate")
-                .header("Pragma", "no-cache")
-                .header("Expires", "0")
+                .header(HttpHeaders.CACHE_CONTROL, "no-cache, no-store, must-revalidate")
+                .header(HttpHeaders.PRAGMA, "no-cache")
+                .header(HttpHeaders.EXPIRES, "0")
                 .entity(fileContent.getContent().getBytes(StandardCharsets.UTF_8))
                 .build();
     }
-Original file line number
+Diff line change
@@ Expand Up / @@ -49,6 +49,7 @@ public class ClaimManagementApi { @@
         private final ClaimManagementApiService delegate;
         public ClaimManagementApi() {
             this.delegate = ClaimManagementApiServiceFactory.getClaimManagementApi();
         }
@@ Expand Down @@