Skip to content

Commit

Permalink
Fix broken i18n in application advanced configuration UI
Browse files Browse the repository at this point in the history
  • Loading branch information
pavinduLakshan committed Feb 15, 2025
1 parent a77093a commit 3c09d47
Show file tree
Hide file tree
Showing 3 changed files with 19 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -146,9 +146,13 @@ export const AdvancedConfigurationsForm: FunctionComponent<AdvancedConfiguration
}
} catch (ex: any) {
onAlertFired({
description: "Error updating the application configuration",
description: t("applications:forms." +
"advancedConfig.sections.clientAttestation.fields." +
"androidAttestationServiceCredentials.errors.invalid.description"),
level: AlertLevels.ERROR,
message: t("Improper JSON format for Android Attestation Service Credentials")
message: t("applications:forms." +
"advancedConfig.sections.clientAttestation.fields." +
"androidAttestationServiceCredentials.errors.invalid.message")
});

return;
Expand Down Expand Up @@ -254,7 +258,7 @@ export const AdvancedConfigurationsForm: FunctionComponent<AdvancedConfiguration
&& Object.keys(androidAttestationServiceCredentialsObject).length) {

errors.androidPackageName = t("applications:forms.advancedConfig." +
"sections.platformSettings.fields." +
"sections.platformSettings.field." +
"android.fields.androidPackageName.validations.emptyForAttestation");
} else if (values.androidPackageName?.toString().trim()
&& !Object.keys(androidAttestationServiceCredentialsObject).length) {
Expand Down
6 changes: 6 additions & 0 deletions modules/i18n/src/models/namespaces/applications-ns.ts
Original file line number Diff line number Diff line change
Expand Up @@ -995,6 +995,12 @@ export interface ApplicationsNS {
empty: string;
invalid: string;
};
errors: {
invalid: {
message: string;
description: string;
}
}
};
};
};
Expand Down
6 changes: 6 additions & 0 deletions modules/i18n/src/translations/en-US/portals/applications.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1203,6 +1203,12 @@ export const applications: ApplicationsNS = {
validations: {
empty: "Google service account credentials are required for client attestation.",
invalid: "Invalid Google service account credentials"
},
errors: {
invalid: {
message: "Error updating the application configuration",
description: "Improper JSON format for Android Attestation Service Credentials"
}
}
}
}
Expand Down

0 comments on commit 3c09d47

Please sign in to comment.