Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed issue of getting 0 results when filtering with 2+ meta attributes #145

Merged
merged 3 commits into from
Jul 22, 2024
Merged

Fixed issue of getting 0 results when filtering with 2+ meta attributes #145

merged 3 commits into from
Jul 22, 2024

Conversation

HasiniSama
Copy link
Contributor

@HasiniSama HasiniSama commented Jul 14, 2024 •
edited
Loading

Purpose

Fixes the issue where the database returns 0 results when filtering with 2 or more meta attributes.
(eg: filter=attributes.x co A and attributes.y co B)

Goals

To get valid results from the database when filtering with 2 or more meta attributes.

Approach

The SQL query now inner joins the UM_ORG_ATTRIBUTE table for each attribute filter.

Related PRs

Related Issues

wso2/product-is#20688

@AnuradhaSK
Copy link
Contributor

Cover this case in unit tests as well

AnuradhaSK
AnuradhaSK previously approved these changes Jul 22, 2024
View reviewed changes
@HasiniSama HasiniSama force-pushed the extending_org_search_feature branch from 863d649 to deb798e Compare July 22, 2024 05:53
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/10035771969

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/10035771969
Status: success

jenkins-is-staging
jenkins-is-staging approved these changes Jul 22, 2024
View reviewed changes
Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/10035771969

@AnuradhaSK AnuradhaSK merged commit 80ca2c5 into wso2:main Jul 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sahandilshan sahandilshan sahandilshan left review comments

@jenkins-is-staging jenkins-is-staging jenkins-is-staging approved these changes

@AnuradhaSK AnuradhaSK AnuradhaSK approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HasiniSama @AnuradhaSK @jenkins-is-staging @sahandilshan