Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ansible-consul : consul config file task is not idempotent #12

Closed
colin-nolan opened this issue Apr 18, 2017 · 4 comments
Closed

ansible-consul : consul config file task is not idempotent #12

colin-nolan opened this issue Apr 18, 2017 · 4 comments
Labels

Comments

@colin-nolan
Copy link
Contributor

Task path: /data/hgi-systems/subrepos/ansible-consul/tasks/install.yml:192

@colin-nolan
Copy link
Contributor Author

colin-nolan commented Apr 18, 2017

Running a diff on the files before and after a change shows changes in the order of the "retry_join" values.

Before:

    "retry_join": [
        "192.168.102.51",
        "192.168.102.47"
    ],

After:

    "retry_join": [
        "192.168.102.47",
        "192.168.102.51"
    ],

@colin-nolan
Copy link
Contributor Author

Needs a | sort here:

"retry_join_wan": [{% for host in consul_servers_wan | difference(ansible_all_ipv4_addresses) %}"{{host}}"{% if not loop.last %}, {% endif %}{% endfor %}],

@colin-nolan
Copy link
Contributor Author

Bug reported upstream: mattfinlayson/ansible-consul#197

@colin-nolan
Copy link
Contributor Author

colin-nolan commented Apr 19, 2017

Pull request with fix pending: mattfinlayson/ansible-consul#198. Switched to using our fork to get the fix without waiting for the merge upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant