Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use hopen for non BAM files #44

Open
jenniferliddle opened this issue Dec 20, 2016 · 5 comments
Open

Use hopen for non BAM files #44

jenniferliddle opened this issue Dec 20, 2016 · 5 comments
Assignees

Comments

@jenniferliddle
Copy link
Contributor

jenniferliddle commented Dec 20, 2016

Replace open() with hopen() throughout, so that we can open files directly from irods or AWS or Google web services.

This will involve replacing the existing XML library used by i2b

@dkj
Copy link
Member

dkj commented Dec 21, 2016

Like! But the XML library replacement sounds like possibly too high a cost.

@jenniferliddle
Copy link
Contributor Author

I don't think so. I wouldn't be trying to write a generic XML parser, but a parser for known, specific XML config files. It shouldn't be too difficult.

@dkj
Copy link
Member

dkj commented Dec 21, 2016

Chatting to our colleagues fopencookie might provide a generic way of obtaining standard file handles from hfile.

@jenniferliddle
Copy link
Contributor Author

Ah Ha!
libXML does provide a xmlParseMemory() function that I can use in place of xmlReadFile(). Which works.
Ok, so I don't get to write my own XML parser. I can live with that :-)

@jenniferliddle jenniferliddle self-assigned this Jan 5, 2017
@jenniferliddle jenniferliddle changed the title Use hts_open Use hopen for non BAM files Jan 10, 2017
@dkj
Copy link
Member

dkj commented Jun 21, 2018

Need to avoid opendir and readdir but as this is only used for instrument file format detection we can probably just try obtaining the different file names/formats for tile1, lane <requested>||1, cycle1 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants