Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove configparser code so it can be reused without all the dependen… #24

Closed
wants to merge 1 commit into from
Closed

Remove configparser code so it can be reused without all the dependen… #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,13 @@ This project adheres to [Semantic Versioning](http://semver.org/).

## [Unreleased]

### Removed

* Config file reader code that can be reused if it's not tied to the multitude
of dependencies in this package

## [0.1.0] - 2024-07-24

### Added

# Initial project scaffold, code and tests
* Initial project scaffold, code and tests
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ SQLAlchemy = { version="^2.0.1", extras=["pymysql"] }
SQLAlchemy-Utils = "^0.41.2"
cryptography = "^44.0.0"
PyYAML = "^6.0.0"
npg_porch_cli = { git="https://github.com/wtsi-npg/npg_porch_cli.git", tag="0.1.0" }
npg_porch_cli = { git="https://github.com/wtsi-npg/npg_porch_cli.git", tag="0.2.0" }
partisan = { url = "https://github.com/wtsi-npg/partisan/releases/download/2.13.0/partisan-2.13.0.tar.gz" }
npg-python-lib = { url = "https://github.com/wtsi-npg/npg-python-lib/releases/download/0.3.4/npg_python_lib-0.3.4.tar.gz" }
requests = "^2.32.0"
Expand Down
75 changes: 0 additions & 75 deletions src/npg_notify/config.py
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion src/npg_notify/db/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
from sqlalchemy.orm import DeclarativeBase, Session
from sqlalchemy_utils import create_database, database_exists, drop_database

from npg_notify.config import get_config_data
from npg_porch_cli.config import get_config_data


def get_db_connection_string(
Expand Down
2 changes: 1 addition & 1 deletion src/npg_notify/porch_wrapper/qc_state.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,11 @@
from pathlib import PurePath
from urllib.parse import urljoin

from npg_notify.config import get_config_data
from npg_notify.db.mlwh import get_study_contacts
from npg_notify.db.utils import get_connection, get_db_connection_string
from npg_notify.mail import generate_email_pac_bio, send_notification
from npg_porch_cli import send_request
from npg_porch_cli.config import get_config_data
from npg_porch_cli.api import Pipeline, PorchAction
from npg_porch_cli.api import send as send_porch_request

Expand Down
Loading