From 9b240ab10f6d567c3b93e7bada126f28989db7a7 Mon Sep 17 00:00:00 2001 From: Marina Gourtovaia Date: Tue, 24 Oct 2023 09:27:36 +0100 Subject: [PATCH] Removed deprecated methods for retrieving lims object descendants --- lib/npg_tracking/data/reference/find.pm | 4 ++-- lib/st/api/lims.pm | 25 ++----------------------- 2 files changed, 4 insertions(+), 25 deletions(-) diff --git a/lib/npg_tracking/data/reference/find.pm b/lib/npg_tracking/data/reference/find.pm index 11b9a380..2e96d48b 100644 --- a/lib/npg_tracking/data/reference/find.pm +++ b/lib/npg_tracking/data/reference/find.pm @@ -222,7 +222,7 @@ sub refs { $spiked_phix_index = $self->lims->spiked_phix_tag_index; } - my @alims = $self->lims->associated_lims; + my @alims = $self->lims->descendants; if (!@alims) { @alims = ($self->lims); } @@ -471,7 +471,7 @@ Marina Gourtovaia Emg8@sanger.ac.ukE =head1 LICENSE AND COPYRIGHT -Copyright (C) 2017 GRL +Copyright (C) 2013,2014,2015,2016,2017,2018,2019,2023 Genome Research Ltd. This file is part of NPG. diff --git a/lib/st/api/lims.pm b/lib/st/api/lims.pm index 47261d51..432d96eb 100644 --- a/lib/st/api/lims.pm +++ b/lib/st/api/lims.pm @@ -543,7 +543,7 @@ sub _build_required_insert_size { my $is_hash = {}; if (defined $self->position) { - my @alims = $self->associated_lims; + my @alims = $self->descendants; @alims = @alims ? @alims : ($self); foreach my $lims (@alims) { if ($lims->is_control) { @@ -1012,20 +1012,6 @@ sub descendants { return @lims; } -=head2 associated_lims - -The same as descendants. Retained for backward compatibility - -=cut -*associated_lims = \&descendants; #backward compat - -=head2 associated_child_lims - -The same as children. Retained for backward compatibility - -=cut -*associated_child_lims = \&children; #backward compat - =head2 children_ia Method providing fast (index-based) access to child lims object. @@ -1071,13 +1057,6 @@ sub sample_publishable_name { return $self->sample_accession_number() || $self->sample_public_name() || $self->sample_name(); } -=head2 associated_child_lims_ia - -The same as children_ia. Retained for backward compatibility - -=cut -*associated_child_lims_ia = \&children_ia; #backward compat - sub _list_of_attributes { my ($self, $attr_name, $with_spiked_control) = @_; my @l = (); @@ -1396,7 +1375,7 @@ Marina Gourtovaia Emg8@sanger.ac.ukE =head1 LICENSE AND COPYRIGHT -Copyright (C) 2013,2014,2015,2016,2017,2018,2019,2020,2021 Genome Research Ltd. +Copyright (C) 2013,2014,2015,2016,2017,2018,2019,2020,2021,2023 Genome Research Ltd. This file is part of NPG.