From 25b53bb8d17da8d2381201b902d489f1309e7df5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C3=ABl=20van=20Diemen?= Date: Wed, 12 Jun 2024 13:59:29 +0200 Subject: [PATCH] Remove live_view setup The setup used to start telemetry for live_view has been changed and merged into `opentelemetry_phoenix` which starts for liveview by default. Meaning this does not need a separate setup process anymore. --- README.md | 2 +- lib/tracing.ex | 4 ---- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/README.md b/README.md index 0be1433..5b84b1f 100644 --- a/README.md +++ b/README.md @@ -39,7 +39,7 @@ defmodule MyApp.Application do ] opts = [...] - Tracing.setup([:phoenix, :live_view, :oban, :aws, :chromic_pdf]) + Tracing.setup([:phoenix, :oban, :aws, :chromic_pdf]) Supervisor.start_link(children, opts) end diff --git a/lib/tracing.ex b/lib/tracing.ex index 97625a0..183eba2 100644 --- a/lib/tracing.ex +++ b/lib/tracing.ex @@ -185,10 +185,6 @@ defmodule Tracing do OpentelemetryPhoenix.setup() end - def setup_element(:live_view) do - OpentelemetryPhoenixLiveView.setup() - end - def setup_element(:oban), do: Tracing.ObanTelemetry.setup() def setup_element(:aws), do: Tracing.AWSTelemetry.setup() def setup_element(:chromic_pdf), do: Tracing.ChromicPDFTelemetry.setup()