Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created duplicate remover oneliner #326

Merged
merged 6 commits into from
Oct 17, 2019
Merged

Conversation

jagw1re
Copy link
Contributor

@jagw1re jagw1re commented Oct 1, 2019

Solution to issue #323

Please describe your program and how to run it.

The program removes duplicates from a given array and outputs it, in one line (excluding variables).


What Programming Language?

C++

It's spaghetti code, but its a one line wonder
@wzhouwzhou
Copy link
Owner

I think the {} around the for loop blocks are optional which qualifies this as actually a one-liner!

@jagw1re
Copy link
Contributor Author

jagw1re commented Oct 1, 2019

Yep, you're right! I've updated it to reflect that change :)

@wzhouwzhou wzhouwzhou added hacktoberfest-accepted Hacktoberfest! Lang: C++ Contributions made in C Plus Plus labels Oct 1, 2019
wzhouwzhou
wzhouwzhou previously approved these changes Oct 1, 2019
Copy link
Owner

@wzhouwzhou wzhouwzhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you'd like, feel free to add your bio to CONTRIBUTORS.md!

@jagw1re
Copy link
Contributor Author

jagw1re commented Oct 1, 2019

Done! Want me to close this request?

@wzhouwzhou
Copy link
Owner

Not yet, we still need to merge it, decide about move it into a dedicated folder for unique_array, etc, but I'll take it from here, thanks!

@jagw1re
Copy link
Contributor Author

jagw1re commented Oct 2, 2019

No worries!

@jagw1re
Copy link
Contributor Author

jagw1re commented Oct 4, 2019

I created a JavaScript solution, so I'll create a new PR instead

wzhouwzhou
wzhouwzhou previously approved these changes Oct 4, 2019
Copy link
Owner

@wzhouwzhou wzhouwzhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@wzhouwzhou wzhouwzhou merged commit 354fd01 into wzhouwzhou:master Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Hacktoberfest! Lang: C++ Contributions made in C Plus Plus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants