Add a langauge-based js redirect to the homepage #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deployment of preview was successful: https://xHain-hackspace-xhain-website-pr-60.surge.sh |
jdwillemse
suggested changes
Feb 20, 2024
There was a problem hiding this comment.
Tested in Safari and Chrome and the solution works.
Client-side redirects are seen as a performance villain and running this through page speed insights makes it complain. I think we really need a backend solution. https://pagespeed.web.dev/analysis/https-xhain-hackspace-xhain-website-pr-60-surge-sh/v6kzhi8trb
|
Thanks for the work already. I'd also clearly prefer a server-side solution. Have you reached out and talked to @gueldenstone already? |
Co-authored-by: jdwillemse <[email protected]>
|
Server-side would obviously be better, but without access to the hosting, this is the best I can do. |
jdwillemse
approved these changes
Feb 23, 2024
|
Closed as the preference is for a server-side solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #47
Tested with firefox 112.0.1 and hugo 0.123.0. I'll test with other browers if the preview builds correctly.
I may add something for browsers that don't support navigator.langauges, but according to MDN all modern browsers do