Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reasoning for choosing VoxelMap instead of other mod #488

Open
jamezrin opened this issue Jul 27, 2020 · 13 comments
Open

Reasoning for choosing VoxelMap instead of other mod #488

jamezrin opened this issue Jul 27, 2020 · 13 comments
Labels
suggestion Feature request

Comments

@jamezrin
Copy link

It's not the first time I see someone having issues with VoxelMap crashing and it has happened to me. It is quite honestly, a pain in the ass.

Out of nowhere it crashes. At least there is something in this modpack that makes it so that crashes don't outright close your game, but still.

Every time someone has this problem with VoxelMap, the suggestion to fix it is to "remove" it, and quite honestly it's the best workaround, because VoxelMap crashes no matter what, at least that is my experience with VoxelMap and this modpack.

The point of this issue is this question:

Why isn't VoxelMap swapped with something more stable already? Like Xaero's Minimap or JourneyMap.
I have started using Xaero's Minimap recently and I think it is a very capable replacement for VoxelMap.
Unfortunately the waypoints aren't imported automatically, I had to do the conversion manually by myself, I haven't had any crashes since I removed VoxelMap.

I wrote a little script to convert VoxelMap waypoints to Xaero's Minimap ones, if someone finds it useful there you go https://github.com/jamezrin/voxel2xaero/

@jamezrin jamezrin added the auto: suggestion This suggestion hasn't been looked at yet label Jul 27, 2020
@xJon xJon added suggestion Feature request and removed auto: suggestion This suggestion hasn't been looked at yet labels Jul 28, 2020
@xJon
Copy link
Owner

xJon commented Jul 28, 2020

As you mentioned yourself, one of the problems with switching the minimap mod of a modpack is players losing their map data & waypoints. I'm happy to see you offer such script although I doubt all players will know how to run Python 3 scripts.
I think that if there was an executable batch file it would make it easier for most players.

That being said, I do agree with you. VoxelMap for 1.12.2 has been very problematic, it's been crashing randomly to many players and it's been incompatible with Botania. I personally tried many times to reach out to VoxelMap's author about the issues, and got minimal respond without any clear intent to resolve things.

I've been hopeful for months now that the author will get the issues fixed but as they seem to more or less ignore my requests, I've been thinking more about a proper replacement.
Additionally, the latest update of VoxelMap includes a cache location change, without any automatic transfer mechanism, which means players who don't necessarily know how to transfer it to the right place would lose all of their data; just like in a minimap mod change.

All of the above means that most likely we will see a minimap mod change in version 1.3.0, but not without a community poll.
I know that a lot of players like VoxelMap and its been The X Packs' signature minimap mod for years, so I'd like to see a majority agreeing for a change before it'd take place.

@xJon
Copy link
Owner

xJon commented Jul 28, 2020

In fact, I will write a batch script to interact with your python script so players using Windows 10 could use it more easily.

If we do end up switching to Xaero's, would you mind if I include your script in the Technic distribution of the modpack?

@jamezrin
Copy link
Author

That being said, I do agree with you. VoxelMap for 1.12.2 has been very problematic, it's been crashing randomly to many players and it's been incompatible with Botania. I personally tried many times to reach out to VoxelMap's author about the issues, and got minimal respond without any clear intent to resolve things.

Yeah, it's a shame this is happening... I really liked VoxelMap, it has a feature I really miss in Xaero (highlight waypoints), but crashes are just unbearable.

All of the above means that most likely we will see a minimap mod change in version 1.3.0, but not without a community poll.
I know that a lot of players like VoxelMap and its been The X Packs' signature minimap mod for years, so I'd like to see a majority agreeing for a change before it'd take place.

Good idea 👍

In fact, I will write a batch script to interact with your python script so players using Windows 10 could use it more easily.

If we do end up switching to Xaero's, would you mind if I include your script in the Technic distribution of the modpack?

You are more than welcome to do so, in any way you want. Though I have to say I haven't tried it with Windows 10, but it should work fine.

@xJon
Copy link
Owner

xJon commented Jul 28, 2020

@jamezrin Apart from the waypoints, do you know anything about the possibility of world map data transfer between the two mods?

@jamezrin
Copy link
Author

jamezrin commented Jul 28, 2020

Are you referring to Xaero's World Map? I didn't know it existed, to be honest I didn't really use the world map in VoxelMap that often so I just took it as a compromise for not crashing.
I assume it is possible but it would be much more involved, I haven't tried Xaero's World Map yet, so I don't know its structure, but VoxelMap exposes a lot of data in binary format which makes things non-trivial, unlike waypoints.

@xJon
Copy link
Owner

xJon commented Jul 28, 2020

Yes, I was referring to Xaero's World Map. No worries, thanks anyway

@jamezrin
Copy link
Author

I have started using Xaero's World Map, and unless I missed something, the only data that Xaero's World Map stores is cache of the terrain, and I'm not sure if something to convert the cache in VoxelMap to Xaero's World Map would be useful.
The structures are bastly different, making it very if not impossible to do externally.

I opened my map and it had a bunch of loading marks, and after a few seconds the terrain started to render.

@xJon
Copy link
Owner

xJon commented Aug 2, 2020

Do you have better insight on reproducing the issues with VoxelMap?
I'd like to test them on its new update.

@jamezrin
Copy link
Author

jamezrin commented Aug 3, 2020

I tried it for a few hours and it hasn't crashed so far...
It was kinda random for me honestly, sometimes it would not happen for a few hours and sometimes it would crash 2 or 3 times in the span of 15 minutes.
I don't have any mana pools in my world so that's something to consider, my crashes were related to light level calculation or whatever

@xJon
Copy link
Owner

xJon commented Aug 3, 2020

It'd be ideal to update VoxelMap instead of switching it out. I will continue to test the new build

@xJon
Copy link
Owner

xJon commented Aug 9, 2020

I was still unable to reproduce crashes while using the latest update so this will stay on hold for now.

@xJon
Copy link
Owner

xJon commented Aug 21, 2020

The issue still seem to be preset yet it is helped by 1.2.1 changes with the Forge config to automatically remove erroring tile entities.
Unfortunately this only helps the Botania incompatibility and not the other crashes.

@xJon
Copy link
Owner

xJon commented Sep 14, 2022

All mentioned issues should be resolved in 1.5.1 thanks to VoxelMap Fixes :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
suggestion Feature request
Projects
None yet
Development

No branches or pull requests

2 participants