You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
TransactionWithReceipt includes transaction_hash, which is not part of the specifications
Description:
It seems that the Transaction struct used within TransactionWithReceipt includes a transaction_hash field. However, according to the Starknet specifications, the transaction_hash should not be part of the transaction object when included as part of a receipt.
Suggested Fix:
To address this issue while maintaining flexibility and clarity, I recommend the following approach:
1. Create a Transaction struct that does not include the transaction_hash field. This struct should be used in contexts where the transaction is part of a receipt or other specification-compliant structure.
2. Introduce a new TransactionWithHash struct that includes the transaction_hash field. This can be used in contexts where the transaction_hash is explicitly required.
The text was updated successfully, but these errors were encountered:
TransactionWithReceipt includes transaction_hash, which is not part of the specifications
Description:
It seems that the Transaction struct used within TransactionWithReceipt includes a transaction_hash field. However, according to the Starknet specifications, the transaction_hash should not be part of the transaction object when included as part of a receipt.
Suggested Fix:
To address this issue while maintaining flexibility and clarity, I recommend the following approach:
1. Create a Transaction struct that does not include the transaction_hash field. This struct should be used in contexts where the transaction is part of a receipt or other specification-compliant structure.
2. Introduce a new TransactionWithHash struct that includes the transaction_hash field. This can be used in contexts where the transaction_hash is explicitly required.
The text was updated successfully, but these errors were encountered: