Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove transaction_hash from Transaction in TransactionWithReceipt to comply with specs #678

Open
jbcaron opened this issue Nov 29, 2024 · 0 comments

Comments

@jbcaron
Copy link
Contributor

jbcaron commented Nov 29, 2024

TransactionWithReceipt includes transaction_hash, which is not part of the specifications

Description:

It seems that the Transaction struct used within TransactionWithReceipt includes a transaction_hash field. However, according to the Starknet specifications, the transaction_hash should not be part of the transaction object when included as part of a receipt.

Suggested Fix:

To address this issue while maintaining flexibility and clarity, I recommend the following approach:
1. Create a Transaction struct that does not include the transaction_hash field. This struct should be used in contexts where the transaction is part of a receipt or other specification-compliant structure.
2. Introduce a new TransactionWithHash struct that includes the transaction_hash field. This can be used in contexts where the transaction_hash is explicitly required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant