Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pager App incorrect decoding and displaying of DAPNET messages (with possible buffer overflow) #14

Open
dl9sec opened this issue May 3, 2024 · 10 comments

Comments

@dl9sec
Copy link

dl9sec commented May 3, 2024

Hi,

unfortunately the App is totally unstable on my Flipper with RogueMaster (RM0429-1240-0.101.3-a5550b3).
After receiving several messages, the App completely freezes, sometimes also when viewing a message.
Leaving the App with the back button is sometimes impossible after some messages received.
The only way to kill the App is to reboot (left+back).
When bigger messages are viewed, the display is garbled (seems, that some of the text is written somewhere on the display).

Regards, Thorsten

@dl9sec dl9sec changed the title Pager app v1.2 is totally unstable... Pager App v1.2 is totally unstable... May 3, 2024
@xMasterX
Copy link
Owner

xMasterX commented May 3, 2024

Looks like your firmware is totally unstable, how about to test it on official firmware for example?
Latest .fap here: https://github.com/xMasterX/all-the-plugins/releases

Screenshot-20240503-130038

@xMasterX xMasterX closed this as completed May 3, 2024
@dl9sec
Copy link
Author

dl9sec commented May 3, 2024

Yes, I tested also with the official firmware and the "latest .fap". Same there.
As soon, as the second message was received the blinking of the LED gets slower. When pressing back button, LED goes off and nothing happens anymore (waited several minutes).
Is there a reason why the "Latest .fap" shows "Version: 0.1" instead of "Version: 1.2"?

@xMasterX
Copy link
Owner

xMasterX commented May 3, 2024

"Version: 1.2"?

This will be fixed

I was unable to replicate anything described, can you provide raw signals that are causing such issues?
Or their full unedited text data?

@dl9sec
Copy link
Author

dl9sec commented May 3, 2024

can you provide raw signals that are causing such issues? Or their full unedited text data?

How? I can not choose DAPNET frequency 439.9875 in the Sub-GHz app...
Edit: Oh, I saw that there is a possibility to edit frequencies in /subghz/assets/settings_user... Will try that

I also tried the latest UnleashedFW 072. Same there.
For me it seems, that transmissions are mixed up in the decoder:

Screenshot-20240503-143055

It seems, that exactly those three messages are mixed up in one receive entry:

2024-05-03 14_31_30-DL9SEC - Digital Voice Tableau – Mozilla Firefox

Maybe this causes an overflow somewhere...

@dl9sec
Copy link
Author

dl9sec commented May 3, 2024

Here is some RAW data. These messages (2..4 in sequence) seems not to be separated correctly by the decoder. After getting such message sequences, the LED blinking frequency decreases and the keypad input seems to be delayed extremely...
Raw-data_examples.zip

@dl9sec
Copy link
Author

dl9sec commented May 3, 2024

The Sub-GHz app seems to behave more better to the sequence messages. They are also mixed up into one message with the RIC of the last received message, but the LED blink frequency doesn't change and the buttons are always responsive....

@xMasterX xMasterX reopened this May 3, 2024
@xMasterX xMasterX changed the title Pager App v1.2 is totally unstable... Pager App incorrect decoding and displaying of DAPNET messages (with possible buffer overflow) May 3, 2024
@dl9sec
Copy link
Author

dl9sec commented May 3, 2024

Thank you for caring about that issue. Let me know, if you need further information.
Regards...

@xMasterX
Copy link
Owner

xMasterX commented May 3, 2024

I will try to replicate the issue using your captures, thanks for sharing

@dl9sec
Copy link
Author

dl9sec commented May 5, 2024

It could be, that the Pi-Star DAPNET gateway is responsible for the decoding problem. Yesterday I got an Alphapoc 602R pager and it has a similar problem decoding such multiple message transmissions (see https://forum.pistar.uk/viewtopic.php?t=4921).
Will see, if some of the Pi-Star guys has an idea...

@dl9sec
Copy link
Author

dl9sec commented May 8, 2024

See also g4klx/DAPNETGateway#35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants