Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for enum #5

Open
neilbaylor opened this issue Mar 13, 2019 · 4 comments
Open

Add support for enum #5

neilbaylor opened this issue Mar 13, 2019 · 4 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@neilbaylor
Copy link

neilbaylor commented Mar 13, 2019

We need enum support for a project i'm working on, I will attempt to open a PR for this in the next day or so

Thanks for this package, its exactly what we needed!

@neilbaylor
Copy link
Author

neilbaylor commented Mar 13, 2019

I've got this working locally, but just realized my prettier config messed up the formatting of all the files i touched.
🤦‍♂️

I'll clean it up tomorrow to match your formatting style and submit a PR.

PS are you using prettier? If so, could you include your config, that would make it easier.

Thanks!

@Necmttn
Copy link
Member

Necmttn commented Mar 15, 2019

we are just using tslint for this project.
how is your prettier lint looks like? I think it's would be good to have some prettier, husky, pre-commit lint scripts for this package.

current tslint.json

{
  "extends": "tslint-config-airbnb"
}

@neilbaylor
Copy link
Author

Awesome, thanks, gonna see if i can unpriettier my local changes and open a few PRs for the features ive been adding.

@lhr0909
Copy link
Member

lhr0909 commented Mar 27, 2019

@neilbaylor Thanks Neil! Looking forward to your PRs!

@lhr0909 lhr0909 added good first issue Good for newcomers help wanted Extra attention is needed labels Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants