Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ListServiceAccounts function to list all service accounts #2012

Merged
merged 5 commits into from
Sep 25, 2024

Conversation

Atoms
Copy link

@Atoms Atoms commented Sep 12, 2024

First try to contribute to this awesome project.

Implementing ListServiceAccounts from https://docs.gitlab.com/ee/api/user_service_accounts.html#list-all-service-account-users

this is pretty straight forward implementation, only once concern i have, as GroupsService also has same functionality, but just for group service accounts.
Therefore reused ListServiceAccountOptions as they are same. If i would change this, then it could break already existing implementations.

this could fix: #2011

@svanharmelen
Copy link
Member

I'm super busy lately... Will try to have a look later this week!

Copy link
Member

@svanharmelen svanharmelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a few small tweaks, but other then that it looks good 👍🏻

@svanharmelen svanharmelen merged commit 27d9adb into xanzy:main Sep 25, 2024
3 checks passed
@Atoms Atoms deleted the serviceaccountlist branch September 25, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ServiceAccounts support
2 participants