From 15c3f2ef36ce0933f619add51813d4f1dbe4e850 Mon Sep 17 00:00:00 2001 From: Andrew Farries Date: Mon, 16 Dec 2024 08:20:27 +0000 Subject: [PATCH] Add testcase for more complex default expression --- pkg/sql2pgroll/alter_table_test.go | 4 ++++ pkg/sql2pgroll/expect/alter_column.go | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/pkg/sql2pgroll/alter_table_test.go b/pkg/sql2pgroll/alter_table_test.go index 90b47af68..071a14105 100644 --- a/pkg/sql2pgroll/alter_table_test.go +++ b/pkg/sql2pgroll/alter_table_test.go @@ -68,6 +68,10 @@ func TestConvertAlterTableStatements(t *testing.T) { sql: "ALTER TABLE foo ALTER COLUMN bar SET DEFAULT now()", expectedOp: expect.AlterColumnOp11, }, + { + sql: "ALTER TABLE foo ALTER COLUMN bar SET DEFAULT (first_name || ' ' || last_name)", + expectedOp: expect.AlterColumnOp12, + }, { sql: "ALTER TABLE foo ADD CONSTRAINT bar UNIQUE (a)", expectedOp: expect.CreateConstraintOp1, diff --git a/pkg/sql2pgroll/expect/alter_column.go b/pkg/sql2pgroll/expect/alter_column.go index 2e4562ddf..adfdbd57b 100644 --- a/pkg/sql2pgroll/expect/alter_column.go +++ b/pkg/sql2pgroll/expect/alter_column.go @@ -95,6 +95,10 @@ var AlterColumnOp11 = &migrations.OpAlterColumn{ Down: sql2pgroll.PlaceHolderSQL, } +var AlterColumnOp12 = &migrations.OpAlterColumn{ + Table: "foo", + Column: "bar", + Default: nullable.NewNullableWithValue("(first_name || ' ') || last_name"), Up: sql2pgroll.PlaceHolderSQL, Down: sql2pgroll.PlaceHolderSQL, }