From 96e50f9c6212584e33a6324de144ccd7b147ad1e Mon Sep 17 00:00:00 2001 From: Ryan Slade Date: Wed, 20 Nov 2024 13:14:13 +0100 Subject: [PATCH] Don't add series for missing row count (#474) Some bechmarks don't include a series for all row count values. Don't add a chart if there is no data for the row count. Fixes an issue with the `ReadSchema` benchmark where we see multiple row count values even though we only populate one of them: Screenshot 2024-11-20 at 12 33 13 --- dev/benchmark-results/build.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/dev/benchmark-results/build.go b/dev/benchmark-results/build.go index f117f85e..002cda87 100644 --- a/dev/benchmark-results/build.go +++ b/dev/benchmark-results/build.go @@ -177,6 +177,9 @@ func generateCharts(reports []BenchmarkReports) []*charts.Line { for _, rowCount := range sortedRowCounts { s := series[rowCount] + if len(s) == 0 { + continue + } name := fmt.Sprintf("%d", rowCount) data := make([]opts.LineData, len(series[rowCount]))