[18.0][MIG] account_statement_import_camt: Migration to 18.0 #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently translated at 75.0% (9 of 12 strings) Translation: bank-statement-import-14.0/bank-statement-import-14.0-account_statement_import_camt Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-14-0/bank-statement-import-14-0-account_statement_import_camt/nl/
Currently translated at 83.3% (10 of 12 strings) Translation: bank-statement-import-14.0/bank-statement-import-14.0-account_statement_import_camt Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-14-0/bank-statement-import-14-0-account_statement_import_camt/it/
Encountered in a Camt.054 statement: currency listed under /BkToCstmrDbtCdtNtfctn/Ntfctn/Ntry/Amt/@ccy
with this commit, the narration field is filled with infos find in the camt file such as reversal indicator, return reason, cheque number, ... before only a banking ref was present. The transaction type field is also filled.
xaviedoanhduy
force-pushed
the
18.0-mig-account_statement_import_camt
branch
from
6fb8d5a
to
123cae4
Compare
Currently translated at 100.0% (12 of 12 strings) Translation: bank-statement-import-16.0/bank-statement-import-16.0-account_statement_import_camt Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_camt/es/
Currently translated at 100.0% (31 of 31 strings) Translation: bank-statement-import-16.0/bank-statement-import-16.0-account_statement_import_camt Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_camt/es/
Currently translated at 22.5% (7 of 31 strings) Translation: bank-statement-import-16.0/bank-statement-import-16.0-account_statement_import_camt Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_camt/it/
This refactoring will allow using `TestParser._do_parse_test()` method for subclasses defined in inheriting modules. This way, if the new module defines new files in other paths than `account_statement_import_camt/test_files/`, subclasses of `TestParser` will still be able to use the `_do_parse_test()` method for imports and checks. Moreover, a custom value can now be defined for the acceptable differing lines number between inputfile and goldenfile. It will also maintain backward compatibility with the current usage of the method (ie: using only a filename with the assumption of finding it in `account_statement_import_camt/test_files/`). NB: methods are now defined outside of `TestParser` to allow importing them directly, instead of inheriting from `TestParser`.
xaviedoanhduy
force-pushed
the
18.0-mig-account_statement_import_camt
branch
from
123cae4
to
50d1750
Compare
xaviedoanhduy
force-pushed
the
18.0-mig-account_statement_import_camt
branch
from
50d1750
to
9c01fca
Compare
thienvh332
suggested changes
Nov 8, 2024
account_statement_import_camt/models/account_statement_import_camt_parser.py
Show resolved
Hide resolved
account_statement_import_camt/models/account_statement_import_camt_parser.py
Show resolved
Hide resolved
account_statement_import_camt/models/account_statement_import_camt_parser.py
Show resolved
Hide resolved
thienvh332
approved these changes
Nov 8, 2024
so final conclusion, i am still genius 💯. |
xaviedoanhduy
force-pushed
the
18.0-mig-account_statement_import_camt
branch
from
9c01fca
to
180fce9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on:
https://github.com/OCA/account-reconcile/pull/738https://github.com/OCA/account-reconcile/pull/739https://github.com/OCA/bank-statement-import/pull/735https://github.com/OCA/bank-statement-import/pull/736base on:
https://github.com/OCA/bank-statement-import/pull/684on this occasion: