Update XdebugVersion.php #94
Conversation
There was a problem hiding this comment.
This patch is most certainly not correct, as it misses the equivalent check in line 410. In any case, what needs to happen is to check whether the value in $this->extensionDir is a relative path or an absolute path. If it's absolute, it should include it, if it's relative, it should not — regardless of whether you're on Windows or not.
|
Sorry for dropping the ball on this. Good catch with line 410. But I still don't understand why we should use absolute paths at all. When we load an extension with path or filename "x", PHP tries to load the physical file extension_dir + "x". The installation instructions recommend putting the Xdebug extension in the extension dir anyway. So regardless of whether the extension_dir is set to an absolute path, or a relativ path, or not set at all, just using the file name of the extension works in all cases IMO. |
|
Absolute paths were required in the PHP 5 days for zend extensions, so that's why the instructions have that. Are you interested in fixing this PR so that I can merge it? |
|
Will do - since PHP 5 is not supported any longer, we go with the relative paths, right? |
|
Yes, that's fine. |
|
I think this PR is no longer relevant, as I've recently updated the logic. I'm therefore closing it. |
Probably fixes #89