Linalg generic-print named ops with hidden regions to match upstream linalg #2959
Labels
bug
Something isn't working
good first issue
Good for newcomers
help wanted
Extra attention is needed
PR #2957 describes a discrepancy between the linalg dialect re-implemented in xdsl and the upstream linalg dialect.
Specifically, linalg named ops are printed correctly in the default pretty printing mode, but the generic printing mode should also print a hidden region.
The above PR #2957 makes the xdsl-opt generic print for AddOp, SubOp, and MulOp, which previously was:
... match the mlir-opt generic print:
Help is wanted in checking if the generic print differs for the following ops between xdsl-opt and mlir-opt, and to fix this in the code:
The
NamedOpBase
class provides standard printing/parsing methods for the commonins
/outs
+variadic syntax employed by linalg named ops, and may be re-used for any of these ops.The text was updated successfully, but these errors were encountered: