WIP feat: move to v13 #1667
Open
WIP feat: move to v13 #1667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also, fix issues with item copy and reference
still need to fix hook for renderSettingsConfig when FVTT converts the core settings interface
This change will preserve the view state on refreshes. But all start out as collapsed on initial opening ****Breaking
prelim - needs more checking
Addresses xdy#1707 - The original AE must still exist or the link is broken.
This was
linked to
issues
Jan 20, 2025
probably makes try obsolete - but it is very robust now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
feature
What is the current behavior? (You can also link to an open issue here)
system incompatible with v13
system uses Dialog (v1)
system uses ItemSheet (v1)
AdvancedSettings uses AppV1
getChatLogEntryContext Hook no longer present in v13
Actor Sheets use AppV1
Consumables and Attachment list reset to default on update
AP Values are only numbers
Can't drag-drop AE's
What is the new behavior (if this is a feature change)?
system mostly runs with v13
refactor to use DialogV2
refactor to ItemSheetV2
refactor AdvancedSettings to ApplicationV2
refactor to TwodsixChatLog that extends core ChatLog and ChatPopout (not mixin?)
Actor Sheets now use app v2
Remove default for consumable lists and preserve state across refresh. All lists initialize to collapsed on first open.
AP values may be formulas
Limited ability to drag-drop Active Effects
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
YES, data migration is one way and older chat message will not function.
Other information: