Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mismatch between equations in the paper #37

Open
xray1111 opened this issue Nov 7, 2024 · 1 comment
Open

mismatch between equations in the paper #37

xray1111 opened this issue Nov 7, 2024 · 1 comment

Comments

@xray1111
Copy link

xray1111 commented Nov 7, 2024

Thank you for the great work, I learned a lot from it.
But I'm kind of confused with equation 7 in section 4.2 and eqation 20 in appendix A, look like a minus sign is missing in eqation 20?

image image
@sowmaster
Copy link

sowmaster commented Nov 19, 2024

I remember noticing this. It should be a typo. The correct one is the one with a minus (eq. 7) so that you maximize the odds ratio.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants