Don't auto-expand Role Manager tree grid on refresh (#3912)

* Fixes #3910
xh · Jan 30, 2025 · 9723f0e · 9723f0e
1 parent 2f7b6df
commit 9723f0e
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,10 @@
 
 ## v73.0.0-SNAPSHOT - unreleased
 
+### 🐞 Bug Fixes
+
+* Fixed Role grid losing view state on refresh.
+
 ## v72.0.0 - 2025-01-27
 
 ### 💥 Breaking Changes

diff --git a/admin/tabs/userData/roles/RoleModel.ts b/admin/tabs/userData/roles/RoleModel.ts
@@ -80,7 +80,7 @@ export class RoleModel extends HoistModel {
             runInAction(() => {
                 this.allRoles = this.processRolesFromServer(data);
             });
-            this.displayRoles();
+            this.displayRoles(loadSpec.isRefresh);
             await this.gridModel.preSelectFirstAsync();
         } catch (e) {
             if (loadSpec.isStale) return;
@@ -212,13 +212,13 @@ export class RoleModel extends HoistModel {
     //------------------
     // Implementation
     //------------------
-    private displayRoles() {
+    private displayRoles(isRefresh?: boolean) {
         const {gridModel} = this,
             gridData = this.showInGroups
                 ? this.processRolesForTreeGrid(this.allRoles)
                 : this.allRoles;
         gridModel.loadData(gridData);
-        gridModel.expandAll();
+        if (!isRefresh) gridModel.expandAll();
         gridModel.autosizeAsync({includeCollapsedChildren: true});
     }