Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require admins to type out Role name as confirm when deleting a Role #3789

Open
amcclain opened this issue Sep 16, 2024 · 1 comment
Open

Comments

@amcclain
Copy link
Member

Client request after an important role was inadvertently deleted in production.

We currently show a confirm with the role name included, but request is to have admin also type out the role name to confirm it is the one they wish to delete, as you see with other similar systems and potentially destructive deletes.

Some things to consider:

  • Make this optional, somehow? I am not averse to this - it's not an onerous requirement - but would there be some case where a development/admin team absolutely can't stand the extra step?
  • Why not for other sensitive items, like configs or prefs?
  • Also include more info in confirm dialog - e.g. clear listing of how many members a role has?
@amcclain
Copy link
Member Author

amcclain commented Oct 8, 2024

Discussed baking this into XH.confirm() - require user to type configured string before lighting up OK button

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants