Removed index_t typedef as it conflicted with a system definition #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
different type (in solaris sys/types.h index_t is a short, rather than our long). Replaced all references with idx_t, which is what it had been a typedef for. In the one file that had further typedef'd idx to index_t, replaced idx with idx_t rather than update the typedef.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solaris has an index_t in sys/types.h that's a short. The MECAT version is a long. I realize you might not care about solaris compilation, but here it is, as I ran across it while hunting down a bug and wanted to remove it as a possible source of problems.
The original typedef was from idx_t (which is itself a typedef) to index_t, and I've simply removed the typedef and replaced index_t with idx_t, except for one file that further typedef'd index_t to idx where I removed the extra typedef and replaced idx with idx_t.