upgrade to Python 3 #61
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't check if this actually breaks PyTeaser for Python 2, but I bumped the version from 1.0 to 2.0 and set the formula as Python 3 only.
I also made https://github.com/goose3/goose3 the only direct dependency. I checked that the tests still pass after installing it with
python3 setup.py installon a fresh install of Ubuntu.How are people using PyTeaser with languages other than English? Are they importing pyteaser and then overwritting
pyteaser.stopWordsbefore callingSummarize? It would be nice to haveSummarize()just take a language parameter directly and maybe add an option to autodetect the article's language withlangdetect, but I don't want to do to much in this one pull request.Closes #56, #44 and #57