Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"EMPTY" preprocessor macro #162

Closed
iyamazaki opened this issue Jan 31, 2025 · 3 comments
Closed

"EMPTY" preprocessor macro #162

iyamazaki opened this issue Jan 31, 2025 · 3 comments

Comments

@iyamazaki
Copy link

The "EMPTY" preprocessor is causing issues with ROCM and CUDA compiler, e.g.,

Can you rename the preprocessor, similarly to what you have done for SuperLU_DIST?
@xiaoyeli
Copy link
Owner

xiaoyeli commented Feb 1, 2025

I changed EMPTY to SLU_EMPTY, and pushed to master. It will show up in the next release.

@iyamazaki
Copy link
Author

Thank you, @xiaoyeli, for the quick response! This has not shown up, but it looks like SuperLU_MT also defines EMPTY.

@xiaoyeli
Copy link
Owner

xiaoyeli commented Feb 3, 2025

yes, I'll fix that in a few days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xiaoyeli @iyamazaki