PR labeling standard #1
j4w8n
announced in
Announcements
Replies: 2 comments
-
Already thinking that |
Beta Was this translation helpful? Give feedback.
0 replies
-
I wonder if some "waiting" labels would be appropriate?
|
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
To keep the community updated on a PR's status, we are implementing the following labels and looking for community feedback.
Labels
considering
- Being talked about; whether to accept or decline.declined
- Not planned. An explanation may be provided. Perhaps not needed, since one would simply close the PR with a comment.accepted
- Planned. The PR may be approved and/or assigned.reviewing
- A member or maintainer has started the process of reviewing the code.testing
- A member or maintainer has started the process of testing the code.abandoned
- Rejected for some reason, after being accepted. An explanation must be provided.queued
ready
- Waiting to be merged. The PR must be approved.merged
- Self-explanatory, and we may not even use this label.reverted
- PR was reverted. An explanation must be provided.We are still working through the details of the label implementation. e.g. If a PR requires
considering
, once it'sdeclined
oraccepted
it makes sense to remove theconsidering
label. However, if a PR isaccepted
, that label might remain when subsequent labels, likereviewing
ortesting
, are added; resulting in two or more labels on a PR at once.Beta Was this translation helpful? Give feedback.
All reactions