Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor]: config #604

Open
themanforfree opened this issue Jan 10, 2024 · 7 comments · May be fixed by #1025
Open

[Refactor]: config #604

themanforfree opened this issue Jan 10, 2024 · 7 comments · May be fixed by #1025
Assignees
@Standing-Man
Labels
good first issue Good for newcomers Improvement Refactor or optimization, including process, performance or something like that

Comments

@themanforfree
Copy link
Collaborator

Now all of our configurations are in a single file, utils/src/config.rs，It also contains a lot of parse_xxx, xxx_format, default_xxx methods, It's messy and difficult to manage. We need to organize these configurations into modules, each containing the configuration itself, its parse method, and default values.

In addition, the configuration can only be created through the new method, which is very inflexible, we need to refactor them use builder pattern, and it should be easy to modify existing configurations
@themanforfree themanforfree added good first issue Good for newcomers Improvement Refactor or optimization, including process, performance or something like that labels Jan 10, 2024
@caicancai
Copy link
Contributor

i want to try it

@caicancai
Copy link
Contributor

Due to my personal time constraints, I abandon this issue. I am very sorry.

@aryan-errs
Copy link

aryan-errs commented Feb 26, 2024 •
edited
Loading

Hey @themanforfree , since caicancai is not working on this issue, i would like to try it out!

@themanforfree
Copy link
Collaborator Author

Hey @themanforfree , since caicancai is not working on this issue, i would like to try it out!

This issue has been assigned to you, thank you for your contribution

@aryan-errs aryan-errs removed their assignment Feb 29, 2024
@qstommyshu
Copy link

Hi, I would like to take a look at this issue. Refactoring seems like a good starting to get to understand the codebase.

@Harsh1s Harsh1s mentioned this issue Mar 6, 2024
Closed
@Phoenix500526
Copy link
Collaborator

@qstommyshu ，Harsh1s has initiate a pull request to solve this issue，can you try another good-first-issue? Thanks 😄

@Standing-Man Standing-Man linked a pull request Nov 18, 2024 that will close this issue
Open
@Standing-Man
Copy link

/assignme

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Standing-Man Standing-Man

Labels
good first issue Good for newcomers Improvement Refactor or optimization, including process, performance or something like that
Projects
None yet
Milestone
No milestone
6 participants
@Phoenix500526 @themanforfree @qstommyshu @caicancai @aryan-errs @Standing-Man