-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Refactor]: Xline logs #516
Comments
Refer to #683 |
@bsbds would like to take on this task |
Hi, @rohansx , would you like to take on this issue? |
@Phoenix500526 Yeah sure i can give it a try |
Hi,@rohansx, I'm glad you're interested in this issue. However, I believe there are some ambiguous points in the issue description, such as how to define the so-called "essential information" in point 2. This may require a deep understanding of the entire project and experience in debugging. IMO, starting with the first point would be relatively easier as a starting point. @bsbds can you give some information for the point two? |
Currently there are serveral issues in the log of Xline:
Log size is huge
During a recent Jepsen test with Xline
debug
level enabled, Xline printed the key-values of every command to logs. This resulted in large log files, as the values can be several tens of kilobytes in size. To address this issue, the logs should be refactored to either use thetracing
level or disable the printing of key-values. Note that this issue may also be present in snapshot related logs.Logs are confusing
The current logs are confusing as they lack essential information required for effective debugging. The logs should include key information, such as propose ID and revisions, to enable easy tracking of command execution.
The text was updated successfully, but these errors were encountered: