-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: reuseable workflow #738
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The validation ci test is failed. Please fix it.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #738 +/- ##
==========================================
- Coverage 75.19% 75.19% -0.01%
==========================================
Files 175 175
Lines 26803 26803
Branches 26803 26803
==========================================
- Hits 20155 20154 -1
- Misses 5438 5440 +2
+ Partials 1210 1209 -1 ☔ View full report in Codecov by Sentry. |
@Phoenix500526 @liangyuanpeng Please review and suggest for any changes and addition/fix in the script. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please modify the third commit message. BTW, you don't need to manually merge the master branch when there are no conflicts. GitHub will automatically rebase and merge it. Therefore, please remove the second commit and squash the first, third, and fourth commits into one."
d4e60fc
to
11959e1
Compare
@Phoenix500526 Just pushed, Please check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise LGTM.
Update to |
Signed-off-by: ChaudharyRaman <[email protected]> change build_xline workflow Signed-off-by: ChaudharyRaman <[email protected]> fix: trailing space Signed-off-by: ChaudharyRaman <[email protected]> feat: bump script version Signed-off-by: ChaudharyRaman <[email protected]>
11959e1
to
2eb0227
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for your work :)
LGTM and thanks, (I don`t have owners here.) |
Got it. Thanks! @bsbds Please Review. |
Signed-off-by: ChaudharyRaman <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@ChaudharyRaman Xline/.github/workflows/pull_request.yml Lines 128 to 151 in eadf2d9
|
@liangyuanpeng Yeah right, I would do that. Currently, I am working on GSOC proposal with dead-line so close, Will create a PR by tomorrow. Thank You. |
@liangyuanpeng, Previously while implementing what i thought is the for |
Fixes #700
Please briefly answer these questions:
what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
Added reuseable workflow and implement in benchmark.yml and validation.yml
what changes does this pull request make?
are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)