Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: reuseable workflow #738

Merged
merged 2 commits into from
Mar 27, 2024
Merged

Conversation

ChaudharyRaman
Copy link
Contributor

@ChaudharyRaman ChaudharyRaman commented Mar 25, 2024

Fixes #700
Please briefly answer these questions:

  • what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
    Added reuseable workflow and implement in benchmark.yml and validation.yml

  • what changes does this pull request make?

  • are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)

Copy link
Collaborator

@Phoenix500526 Phoenix500526 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The validation ci test is failed. Please fix it.

.github/workflows/validation.yml Outdated Show resolved Hide resolved
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.19%. Comparing base (85e7891) to head (58f001b).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #738      +/-   ##
==========================================
- Coverage   75.19%   75.19%   -0.01%     
==========================================
  Files         175      175              
  Lines       26803    26803              
  Branches    26803    26803              
==========================================
- Hits        20155    20154       -1     
- Misses       5438     5440       +2     
+ Partials     1210     1209       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChaudharyRaman
Copy link
Contributor Author

@Phoenix500526 @liangyuanpeng Please review and suggest for any changes and addition/fix in the script.

Copy link
Collaborator

@Phoenix500526 Phoenix500526 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please modify the third commit message. BTW, you don't need to manually merge the master branch when there are no conflicts. GitHub will automatically rebase and merge it. Therefore, please remove the second commit and squash the first, third, and fourth commits into one."

@ChaudharyRaman
Copy link
Contributor Author

@Phoenix500526 Just pushed, Please check

Phoenix500526
Phoenix500526 previously approved these changes Mar 26, 2024
Copy link
Collaborator

@Phoenix500526 Phoenix500526 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@liangyuanpeng liangyuanpeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM.

.github/workflows/validation.yml Outdated Show resolved Hide resolved
.github/workflows/validation.yml Outdated Show resolved Hide resolved
@liangyuanpeng
Copy link
Contributor

This PR resolved this issue - #700

Update to Fixes #700, and then it will auto close the issue when this PR is merged.

Signed-off-by: ChaudharyRaman <[email protected]>

change build_xline workflow

Signed-off-by: ChaudharyRaman <[email protected]>

fix: trailing space

Signed-off-by: ChaudharyRaman <[email protected]>

feat: bump script version

Signed-off-by: ChaudharyRaman <[email protected]>
Copy link
Contributor

@liangyuanpeng liangyuanpeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your work :)

Phoenix500526
Phoenix500526 previously approved these changes Mar 26, 2024
@liangyuanpeng
Copy link
Contributor

requested a review from liangyuanpeng

LGTM and thanks, (I don`t have owners here.)

@ChaudharyRaman
Copy link
Contributor Author

LGTM! Thanks for your work :)

Got it. Thanks! @bsbds Please Review.

Copy link
Collaborator

@Phoenix500526 Phoenix500526 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Phoenix500526 Phoenix500526 merged commit d4424cd into xline-kv:master Mar 27, 2024
13 of 14 checks passed
@liangyuanpeng
Copy link
Contributor

@ChaudharyRaman
I think we still update here, do you want to continue it?

- name: Build xline image
run: |
docker run -q --rm -v $(pwd):/xline \
-e SCCACHE_GHA_ENABLED=on \
-e ACTIONS_CACHE_URL=${ACTIONS_CACHE_URL} \
-e ACTIONS_RUNTIME_TOKEN=${ACTIONS_RUNTIME_TOKEN} \
ghcr.io/xline-kv/build-env:latest \
cargo build --release --bin xline --bin benchmark --bin validation_lock_client
sudo apt-get install -y --force-yes expect
cd scripts
cp ../target/release/{xline,benchmark,validation_lock_client} .
ldd ./xline
ldd ./benchmark
cp ../fixtures/{private,public}.pem .
docker build . -t ghcr.io/xline-kv/xline:master
cd ..
pwd
mkdir -p _output
docker save -o _output/xline.tar ghcr.io/xline-kv/xline:master
ls _output
- uses: actions/upload-artifact@v4

@ChaudharyRaman
Copy link
Contributor Author

@liangyuanpeng Yeah right, I would do that. Currently, I am working on GSOC proposal with dead-line so close, Will create a PR by tomorrow. Thank You.

@ChaudharyRaman
Copy link
Contributor Author

@liangyuanpeng, Previously while implementing what i thought is the for actions/upload-artifact@v4 , we are using for upload Log and Benchmark, and since Upload logs depends on failure() || cancelled(). Its better to let it be there and so instead of creating new Upload, lets create a general Case for rest including Benchmark and _output/xline.tar. What do you say.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Create a reusable gh workflow for build xline image
4 participants