-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove DB generic #806
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #806 +/- ##
==========================================
+ Coverage 75.55% 75.70% +0.15%
==========================================
Files 180 187 +7
Lines 26938 27822 +884
Branches 26938 27822 +884
==========================================
+ Hits 20353 21063 +710
- Misses 5366 5470 +104
- Partials 1219 1289 +70 ☔ View full report in Codecov by Sentry. |
Though xline currently has only one StorageApi impl,the generic is make sense for the community if someone want to use another storage engine. |
The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we remove the DB generic here, is it necessary to keep StorageApi
trait?
removed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please squash these commits into one commit
Signed-off-by: bsbds <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Please briefly answer these questions:
what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
The DB generic is redundant as no other type will ever implement
StorageApi
in Xline. This change aims to enhance readability of the codebase.what changes does this pull request make?
are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)