-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: xline command execution #808
refactor: xline command execution #808
Conversation
84a437a
to
52b4640
Compare
@bsbds You've modified the workflows. Please don't forget to update the .mergify.yml. |
031671c
to
40439ad
Compare
@bsbds You've modified the workflows. Please don't forget to update the .mergify.yml. |
40439ad
to
d99bb7e
Compare
c90a838
to
94e9256
Compare
83f2f51
to
e3caa90
Compare
@bsbds Convert your pr to draft since CI failed |
775c1b7
to
d904201
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please squash these commits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, please squash these commits.
52a9aa0
to
82b817f
Compare
@bsbds You've modified the workflows. Please don't forget to update the .mergify.yml. |
Signed-off-by: bsbds <[email protected]>
Signed-off-by: bsbds <[email protected]> chore: add reminder of a revision issue Signed-off-by: bsbds <[email protected]>
Signed-off-by: bsbds <[email protected]>
Signed-off-by: bsbds <[email protected]>
82b817f
to
6fa579c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
9b78057
into
xline-kv:refactor-v0.7.0-new
Depends-On: #687 #807 #673 #853
This PR refactors xline kv storage and xline command executor.
Some tests will not be fixed in this PR; they will be fixed in #821.
Please briefly answer these questions:
what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
what changes does this pull request make?
are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)