Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use a custom OptionalU64 to replace optional uint64 #26

Merged
merged 1 commit into from
Aug 23, 2024
Merged

refactor: use a custom OptionalU64 to replace optional uint64 #26

merged 1 commit into from
Aug 23, 2024

Conversation

bsbds
Copy link
Collaborator

@bsbds bsbds commented Aug 1, 2024 •
edited
Loading

@bsbds bsbds force-pushed the remove-optional branch from 8dc60e8 to 2d81c8f Compare August 1, 2024 01:50
Phoenix500526
Phoenix500526 approved these changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@Phoenix500526 Phoenix500526 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bsbds bsbds merged commit e26a7cb into xline-kv:main Aug 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lxl66566 lxl66566 lxl66566 approved these changes

@Phoenix500526 Phoenix500526 Phoenix500526 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bsbds @Phoenix500526 @lxl66566